Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address type errors in 'cleo._utils' #122

Merged
merged 7 commits into from
Sep 5, 2022
Merged

address type errors in 'cleo._utils' #122

merged 7 commits into from
Sep 5, 2022

Conversation

danieleades
Copy link
Contributor

this is stacked on #121

@danieleades danieleades marked this pull request as ready for review May 28, 2022 00:21
@danieleades
Copy link
Contributor Author

@branchvincent this is rebased and ready for review

@danieleades danieleades force-pushed the typing/cleo._utils branch 3 times, most recently from 7b633ad to 84ff5fb Compare May 28, 2022 20:37
branchvincent
branchvincent requested changes May 28, 2022
View reviewed changes
cleo/_utils.py Outdated Show resolved Hide resolved
cleo/_utils.py Outdated Show resolved Hide resolved
danieleades
danieleades commented Jun 3, 2022
View reviewed changes
tests/test_utils.py Outdated
Comment on lines 6 to 11
(0.1, "< 1 sec"),
(1.0, "1 sec"),
(2.0, "2 secs"),
(59.0, "59 secs"),
(60.0, "1 min"),
(120.0, "2 mins"),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@branchvincent do these test cases match your expectations? (this is failing, currently)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, makes sense to me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. That means there's a bug with the current implementation.
I'll need to find some time to revisit this. Was a while ago...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha of course! take your time, thanks a lot for helping out

@danieleades danieleades marked this pull request as draft June 3, 2022 05:07
@Secrus
Copy link
Member

Secrus commented Jul 12, 2022

Any progress on this? Anything you need help with?

@danieleades
Copy link
Contributor Author

Any progress on this? Anything you need help with?

a response to this comment would be handy - #122 (comment)

Secrus
Secrus previously requested changes Jul 27, 2022
View reviewed changes
Copy link
Member

@Secrus Secrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to update your code with changes from the master branch since _utils module and its tests changed.

tests/test_utils.py Outdated Show resolved Hide resolved
@branchvincent branchvincent mentioned this pull request Jul 27, 2022
Closed
@Secrus Secrus mentioned this pull request Sep 4, 2022
Closed
@Secrus Secrus marked this pull request as ready for review September 4, 2022 22:54
@Secrus
Copy link
Member

Secrus commented Sep 4, 2022

@danieleades hope you don't mind, I took it upon myself and fixed the bug and lingering mypy issue.

@Secrus Secrus dismissed their stale review September 4, 2022 22:57

Added code to that, not eligible to review that anymore

@Secrus Secrus requested a review from a team September 5, 2022 07:45
@danieleades
Copy link
Contributor Author

@danieleades hope you don't mind, I took it upon myself and fixed the bug and lingering mypy issue.

no problem here! LGTM

@branchvincent branchvincent merged commit 37d4e48 into python-poetry:main Sep 5, 2022
@branchvincent
Copy link
Member

thanks again @danieleades!

@Secrus Secrus mentioned this pull request Sep 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@branchvincent branchvincent branchvincent approved these changes

@Secrus Secrus Secrus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danieleades @Secrus @branchvincent