Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release refinement #7074

Merged
merged 7 commits into from
Apr 10, 2023
Merged

Release refinement #7074

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
900db50
Move 'git push --all' later
hugovk Apr 8, 2023
3490896
Flip order to give slower macOS/Linux a headstart
hugovk Apr 8, 2023
c9ec517
Give examples how to download binary releases using gh CLI
hugovk Apr 8, 2023
47ac51c
Update PEP links to redirects
hugovk Apr 8, 2023
6a3c399
Fix typo
hugovk Apr 9, 2023
08b5539
Move "git push" commands later
radarhere Apr 9, 2023
cb68187
Clarify command should be run from main repo
hugovk Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Give examples how to download binary releases using gh CLI
  • Loading branch information
@hugovk
hugovk committed Apr 10, 2023
commit c9ec517b4d2bd44cf7905d8fcb7e37c01c21541c
11 changes: 9 additions & 2 deletions RELEASING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,18 @@ Released as needed privately to individual vendors for critical security-related
./update-pillow-tag.sh [[release tag]]
```
* [ ] Download wheels from the [Pillow Wheel Builder release](https://github.com/python-pillow/pillow-wheels/releases)
and copy into `dist/`
and copy into `dist/`. For example using [GitHub CLI](https://github.com/cli/cli):
```bash
gh release download --dir dist --pattern "*.whl" --repo python-pillow/pillow-wheels
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gather you were thinking that this command would be run from the main repository, so that all of the files would be in one neat 'dist' directory.

However, in the previous point, the user cloned and navigated into pillow-wheels. So I feel like this is confusing. It would be good to either clarify that this should be run from the main repository, or if this is run from pillow-wheels, then --repo python-pillow/pillow-wheels is unnecessary.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right, I ran both these commands from the main repo, and agree this is confusing. Will clarify!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added cb68187 (and rebased in the PyQt workaround).

```

### Windows
* [ ] Download the artifacts from the [GitHub Actions "Test Windows" workflow](https://github.com/python-pillow/Pillow/actions/workflows/test-windows.yml)
and copy into `dist/`
and copy into `dist/`For example using [GitHub CLI](https://github.com/cli/cli):
hugovk marked this conversation as resolved.
Show resolved Hide resolved
```bash
gh run download --dir dist
# select dist-x.y.z
```

## Publicize Release

Expand Down