Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close OleFileIO instance when closing or exiting FPX or MIC #7005

Merged
merged 2 commits into from
Mar 12, 2023

Conversation

radarhere
Copy link
Member

There are various unclosed file warnings in GHA for main at the moment. Most of them are problems in the tests, and I've fixed those here, but there are also warnings for unclosed FPX and MIC files.

Those two formats use OleFileIO. This PR fixes those by closing self.ole when closing or exiting images of those formats.

@hugovk hugovk merged commit be244b5 into python-pillow:main Mar 12, 2023
@radarhere radarhere deleted the unclosed_file branch March 12, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants