-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMPAT: fix numpy 2.0 incompatibility #723
Conversation
The CI still did not pick up numpy 2 in dev env... I am afraid I'd need to manually install it in another step as it gets pulled by plenty of other deps before we get to the pip part. I will revert that and keep just that fix. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #723 +/- ##
=====================================
Coverage 83.9% 83.9%
=====================================
Files 145 145
Lines 15583 15583
=====================================
Hits 13077 13077
Misses 2506 2506
|
Are we going to fix the failure in the PR or in a subsequent PR? |
I'd say so. I don't know why we see it, so it will require more time to figure out. |
Closes #722
The issue probably won't pop-up for users given it is in the legacy implementation you would need to import directly.
Also adding numpy nightly to dev env.