Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPAT: fix numpy 2.0 incompatibility #723

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Conversation

martinfleis
Copy link
Member

Closes #722

The issue probably won't pop-up for users given it is in the legacy implementation you would need to import directly.

Also adding numpy nightly to dev env.

@martinfleis
Copy link
Member Author

The CI still did not pick up numpy 2 in dev env... I am afraid I'd need to manually install it in another step as it gets pulled by plenty of other deps before we get to the pip part. I will revert that and keep just that fix.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.9%. Comparing base (e82d1be) to head (0a9a58f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #723   +/-   ##
=====================================
  Coverage   83.9%   83.9%           
=====================================
  Files        145     145           
  Lines      15583   15583           
=====================================
  Hits       13077   13077           
  Misses      2506    2506           
Files Coverage Δ
libpysal/cg/voronoi.py 73.7% <100.0%> (ø)
libpysal/examples/remotes.py 76.4% <100.0%> (ø)

@jGaboardi
Copy link
Member

Are we going to fix the failure in the PR or in a subsequent PR?

@martinfleis
Copy link
Member Author

Are we going to fix the failure in the PR or in a subsequent PR?

I'd say so. I don't know why we see it, so it will require more time to figure out.

@jGaboardi jGaboardi merged commit a92290b into pysal:main Jun 19, 2024
10 of 11 checks passed
@martinfleis martinfleis deleted the numpy2 branch June 19, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure due to numpy 2.0 deprecation
3 participants