GHA: allow multi-core testing again #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #636 +/- ##
=======================================
- Coverage 84.5% 83.9% -0.6%
=======================================
Files 139 139
Lines 14972 14972
=======================================
- Hits 12647 12559 -88
- Misses 2325 2413 +88 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #606
The issue comes from pooch. Multiple workers are trying to download the archive at the same time, corrupting the file in the process. Or second worker is trying to read partially downloaded archive that the first one is still writing. We do avoid this with libpysal.examples by fetching them ahead of the time. We can do the same with geodatasets.