Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant .coveragerc #604

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Conversation

jGaboardi
Copy link
Member

This PR resolves #602.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #604 (7dd0eb2) into main (b6a03f2) will increase coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #604     +/-   ##
=======================================
+ Coverage   83.9%   84.1%   +0.2%     
=======================================
  Files        127     137     +10     
  Lines      14804   14781     -23     
=======================================
+ Hits       12420   12435     +15     
+ Misses      2384    2346     -38     

see 36 files with indirect coverage changes

@martinfleis
Copy link
Member

The contents we have in pyproject does not match coveragerc for a reason?

@jGaboardi
Copy link
Member Author

jGaboardi commented Oct 24, 2023

Good question. The contents in pyproject.toml were only certainly copied over from another submodules.

  • The stuff in .coveragerc is archaic:
    • paths contrib, test don't exist anymore
    • disable_warnings doesn't seem to be the same as it previosly was?
  • The stuff in pyproject.toml also contains listings that don't appear in libpysal: "if self.debug:", "pragma: no cover"

Is there anything else you'd like to see in pyproject.toml that I missing?

Also, I wonder if there is any reason not to be using pytest-xdist in libpysal? Currently, the test suite can take up to 10 minutes to run. Let's try to cut that back.

@jGaboardi
Copy link
Member Author

I wonder if there is any reason not to be using pytest-xdist in libpysal?

Perhaps this has something to do with it?

ERROR libpysal/graph/tests/test_kernel.py - fiona.errors.DriverError: .shp file is unreadable, or corrupt.
ERROR libpysal/graph/tests/test_triangulation.py - fiona.errors.DriverError: .shp file is unreadable, or corrupt.
ERROR gw0

@jGaboardi
Copy link
Member Author

Pretty significant runtime decrease in some, negligible in others. Any thoughts on the fiona.errors.DriverError, @martinfleis ?

@martinfleis
Copy link
Member

I wonder if there is any reason not to be using pytest-xdist in libpysal?

I have removed it recently precisely for the file access conflicts. We can try to resolve those by designing the test differently but let's deal with it separately if you feel this will significantly help.

@martinfleis
Copy link
Member

Is there anything else you'd like to see in pyproject.toml that I missing?

not really, I was just wondering why the difference.

@jGaboardi jGaboardi merged commit 6ae2575 into pysal:main Oct 24, 2023
10 checks passed
@jGaboardi jGaboardi deleted the remove_coverarc branch October 24, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove .coveragerc
2 participants