Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruff exclusions to pyproject.toml #2537

Merged

Conversation

correctmost
Copy link
Contributor

Type of Changes

Type
🔨 Refactoring

Description

This makes it easier to run ruff check outside of the pre-commit hook:

Before

$ ruff check --output-format=concise
tests/testdata/python3/data/absimp/string.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tests/testdata/python3/data/all.py:5:10: E701 Multiple statements on one line (colon)
tests/testdata/python3/data/appl/myConnection.py:1:1: I001 [*] Import block is un-sorted or un-formatted

[...snip...]

After

$ ruff check --output-format=concise
All checks passed!

This makes it easier to run 'ruff check' outside of the pre-commit
hook.
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.98%. Comparing base (78f7f60) to head (d0c4021).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2537   +/-   ##
=======================================
  Coverage   92.98%   92.98%           
=======================================
  Files          93       93           
  Lines       11048    11048           
=======================================
  Hits        10273    10273           
  Misses        775      775           
Flag Coverage Δ
linux 92.85% <ø> (ø)
pypy 92.98% <ø> (ø)
windows 92.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Sep 4, 2024
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) September 4, 2024 05:59
@Pierre-Sassoulas Pierre-Sassoulas merged commit 6deb34f into pylint-dev:main Sep 4, 2024
21 checks passed
@correctmost correctmost deleted the cm/ruff-local-exclusions branch September 5, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants