Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the documentation and the error message of modpath_from_file #2532

Merged

Conversation

temyurchenko
Copy link
Contributor

The doc should clarify that the search will always include sys.path.

The error message should reflect the actual paths used for checking.

Type of Changes

Type
📜 Docs

The doc should clarify that the search will always include sys.path.

The error message should reflect the actual paths used for checking.
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.98%. Comparing base (a389ef7) to head (c551ff9).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2532      +/-   ##
==========================================
- Coverage   92.98%   92.98%   -0.01%     
==========================================
  Files          93       93              
  Lines       11049    11048       -1     
==========================================
- Hits        10274    10273       -1     
  Misses        775      775              
Flag Coverage Δ
linux 92.85% <ø> (-0.01%) ⬇️
pypy 92.98% <ø> (-0.01%) ⬇️
windows 92.96% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
astroid/modutils.py 89.47% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👌

@Pierre-Sassoulas Pierre-Sassoulas merged commit 37b6c0d into pylint-dev:main Aug 30, 2024
21 checks passed
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.4.0 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants