Support ETags for Azure and Google Cloud [#176, #177] #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbarry
reviewed
Sep 9, 2024
Comment on lines
+217
to
+243
| func TestSetProviderEtagAws(t *testing.T) { | ||
| var awsV1Req s3.GetObjectInput | ||
| assert.Nil(t, awsV1Req.IfMatch) | ||
| asFunc := func(i interface{}) bool { | ||
| v, ok := i.(**s3.GetObjectInput) | ||
| if ok { | ||
| *v = &awsV1Req | ||
| } | ||
| return true | ||
| } | ||
| setProviderEtag(asFunc, "123") | ||
| assert.Equal(t, aws.String("123"), awsV1Req.IfMatch) | ||
| } | ||
|
|
||
| func TestSetProviderEtagAzure(t *testing.T) { | ||
| var azOptions azblob.DownloadStreamOptions | ||
| assert.Nil(t, azOptions.AccessConditions) | ||
| asFunc := func(i interface{}) bool { | ||
| v, ok := i.(**azblob.DownloadStreamOptions) | ||
| if ok { | ||
| *v = &azOptions | ||
| } | ||
| return ok | ||
| } | ||
| setProviderEtag(asFunc, "123") | ||
| assert.Equal(t, azcore.ETag("123"), *azOptions.AccessConditions.ModifiedAccessConditions.IfMatch) | ||
| } |
There was a problem hiding this comment.
Could you have a similar test for google cloud?
There was a problem hiding this comment.
I wasn't able to since conditions is not a public field of the gcp interface (is write-only through the If function)
There was a problem hiding this comment.
Ok got it. This is probably as good as we can get on testing short of standing up a mock implementation of the provider's API 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@akhenakh @msbarry