Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple of ARM64-related fixes #934

Merged
merged 2 commits into from
May 14, 2018
Merged

Conversation

akopytov
Copy link
Contributor

@akopytov akopytov commented May 3, 2018

No description provided.

Signed-off-by: Alexey Kopytov <akopytov@gmail.com>
…4k pages.

Signed-off-by: Alexey Kopytov <akopytov@gmail.com>
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should get aarch64 into our buildkite setup.

@discordianfish
Copy link
Member

LGTM

@discordianfish discordianfish merged commit dd98a09 into prometheus:master May 14, 2018
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
* Do not rely on AArch64 CPUs to support 32-bit ARM for cross-testing.

Signed-off-by: Alexey Kopytov <akopytov@gmail.com>

* aarch64 like ppc64le reports 64k node_sockstat_TCP_mem_bytes due to 64k pages.

Signed-off-by: Alexey Kopytov <akopytov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants