Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 0.13.0-rc.1 release. #313

Merged
merged 3 commits into from
Oct 16, 2016
Merged

Prepare for 0.13.0-rc.1 release. #313

merged 3 commits into from
Oct 16, 2016

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented Sep 26, 2016

  • Update CHANGELOG.md.
  • Update VERSION.

@mdlayher
Copy link
Contributor

Do it! 👍

@sdurrheimer
Copy link
Contributor

IMO version should be 0.13.0-rc.1 to be consistent with prometheus.

* Update CHANGELOG.md.
* Update VERSION.
@SuperQ
Copy link
Member Author

SuperQ commented Oct 16, 2016

@sdurrheimer Fixed version and rebased. Updated CHANGELOG with a couple additional features.

@SuperQ SuperQ changed the title Prepare for 0.13.0rc1 release. Prepare for 0.13.0-rc.1 release. Oct 16, 2016
@@ -1,3 +1,28 @@
## 0.13.0 / 2016-09-26
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We switched to including v in version identifiers. Until v0.13.0 is released this should not include a date, e.g. v0.13.0 / unreleased.

* [BUGFIX] Close file handler in textfile #263
* [BUGFIX] Ignore partitions on NVME devices by default #268
* [BUGFIX] Fix mdstat tabs parsing #275
* [BUGFIX] Convert netstat collector to use ConstMetrics #281
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the ConstMetrics changes are relevant to end users. Let's remove these changelog entries. See the discussion at prometheus/prometheus#2059 (comment) for more info.

Copy link
Member

@grobie grobie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ SuperQ merged commit 2ff8e5f into master Oct 16, 2016
@SuperQ SuperQ deleted the superq/v0.13.0rc1 branch October 16, 2016 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants