Calculate Linux disk bytes read/written based on sector size #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdf
force-pushed
the
diskstats_linux_bytes_read_written
branch
3 times, most recently
from
f2473bc
to
333afa7
Compare
|
It should be possible to make this work for partitions by walking up the sysfs tree if that's desirable, and that would avoid the hacky line size check in |
pdf
force-pushed
the
diskstats_linux_bytes_read_written
branch
from
333afa7
to
099b8be
Compare
| return parseDiskSectorSize(file) | ||
| } | ||
|
|
||
| func parseDiskSectorSize(r io.Reader) (string, error) { |
There was a problem hiding this comment.
The conntrack module has a function for this already
There was a problem hiding this comment.
Gotcha, can move this out to helpers.go
Logical sector size appears to be fixed at 512B for the foreseeable future in the kernel, so for now we just hard-code it.
pdf
force-pushed
the
diskstats_linux_bytes_read_written
branch
from
099b8be
to
09e610a
Compare
|
Hard-coding the sector size certainly simplifies things, though I wonder if it's worth including this if we're going just going to make this assumption, since it can be fairly easily scaled by query. |
|
I think it's worthwhile. We generally want things to be in bytes, and users not having to worry about the nitty-gritty of kernel internals is good. |
brian-brazil
added a commit
that referenced
this pull request
Dec 28, 2015
Calculate Linux disk bytes read/written based on sector size
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only calculated for raw devices, since determinining the parent
device for partitions would require additional work, and partitions are
excluded from collection by default.