Add context reasons to notifications failed counter #3631
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alertmanager cancels the Dispatcher context when it receives a reload request, which cancels in-flight notifications and counts them as failed with reason "other".
This change adds two new reasons for context cancellation and deadline exceeding. It sets the reason in the counter if no other error was raised in previous attempts. It is helpful to monitor for failed requests, but at the same time, be able to discard failures from contexts canceled due to reloads or sigterms.