Add support for SQL Errors counter

[btshft]

No description provided.

[martinlindhe]

SQLErrorsErrors sounds rather redundant. What about naming it simply SQLErrors?

[btshft]

SQLErrorsErrors sounds rather redundant. What about naming it simply SQLErrors?

I agree, naming looks redundant. I've tried to keep things in consist with original naming pattern: [CategoryName]+[Counter name]. But if it's required I can remove "Errors" suffix. Just to clarify, should I rename counter name too? So it will become {prefix}_sqlerrors instead of {prefix}_sqlerrors_errors

[carlpett]

How about {prefix}_sql_errors_total? That'd be in line with the general Prometheus recommendations.

[carlpett]

Thanks @callvirtual! Just did a quick check in the docs you linked (https://docs.microsoft.com/en-us/sql/relational-databases/performance-monitor/sql-server-sql-errors-object), and there it seems there are multiple errors tracked. Are these all summed up in this collector?

[btshft]

How about {prefix}_sql_errors_total? That'd be in line with the general Prometheus recommendations.

Agreed, a good suggestion. I have already uploaded the fix. Tell me if something else needs to be fixed.

[btshft]

Thanks @callvirtual! Just did a quick check in the docs you linked (https://docs.microsoft.com/en-us/sql/relational-databases/performance-monitor/sql-server-sql-errors-object), and there it seems there are multiple errors tracked. Are these all summed up in this collector?

There's how it looks (don't have real db with errors on laptop right now but it works fine, already tested)
https://i.imgur.com/kITXnNX.png

So the errors count can be split up by resource label in different buckets according to docs.

[carlpett]

Ah, great. Then this looks good to me!

[carlpett]

Thanks!

[btshft]

I also plan to add support for Transactions counters soon as well. Will send PR in a couple days