-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build calico windows upgrade image #1278
Merged
lmm
merged 16 commits into
projectcalico:master
from
lmm:lmm-calico-windows-upgrade-image
Oct 29, 2021
Merged
Build calico windows upgrade image #1278
lmm
merged 16 commits into
projectcalico:master
from
lmm:lmm-calico-windows-upgrade-image
Oct 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
song-jiang
reviewed
Oct 22, 2021
windows-upgrade/Dockerfile
Outdated
COPY --from=base /CalicoUpgrade /CalicoUpgrade | ||
COPY --from=base /CalicoBin /CalicoBin | ||
|
||
ENTRYPOINT ["cmd.exe", "/C", "xcopy /y c:\\CalicoBin c:\\CalicoUpgrade & ping -t localhost > NUL"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
lmm
force-pushed
the
lmm-calico-windows-upgrade-image
branch
from
October 28, 2021 21:17
0eac506
to
a8a0fe2
Compare
lmm
changed the title
wip: build calico windows upgrade image
Build calico windows upgrade image
Oct 28, 2021
song-jiang
approved these changes
Oct 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM.
lmm
force-pushed
the
lmm-calico-windows-upgrade-image
branch
from
October 29, 2021 19:33
10373ed
to
b8894bd
Compare
lmm
added a commit
to lmm/node
that referenced
this pull request
Oct 29, 2021
* Add building of calico windows upgrade image
lmm
added a commit
that referenced
this pull request
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds building of the calico/windows-upgrade image.
Output of some make targets added:
make build-windows-upgrade-image
: https://gist.github.com/lmm/c44afeb88a9412baa66cfa417a630b65make cd-windows-upgrade
with dry run: https://gist.github.com/lmm/280a30abd3e3c1de148247ee27e64ed1CONFIRM=true make cd-windows-upgrade
: https://gist.github.com/lmm/fb2c5689db6d586de7cd442a88204be2Todos
Release Note