Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build calico windows upgrade image #1278

Merged
merged 16 commits into from
Oct 29, 2021

Conversation

lmm
Copy link
Contributor

@lmm lmm commented Oct 22, 2021

Description

This PR adds building of the calico/windows-upgrade image.

Output of some make targets added:

Todos

  • Tests
  • Documentation
  • Release note

Release Note

None required

COPY --from=base /CalicoUpgrade /CalicoUpgrade
COPY --from=base /CalicoBin /CalicoBin

ENTRYPOINT ["cmd.exe", "/C", "xcopy /y c:\\CalicoBin c:\\CalicoUpgrade & ping -t localhost > NUL"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@lmm lmm force-pushed the lmm-calico-windows-upgrade-image branch from 0eac506 to a8a0fe2 Compare October 28, 2021 21:17
@lmm lmm changed the title wip: build calico windows upgrade image Build calico windows upgrade image Oct 28, 2021
@lmm lmm marked this pull request as ready for review October 28, 2021 22:54
Copy link
Member

@song-jiang song-jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

@lmm lmm force-pushed the lmm-calico-windows-upgrade-image branch from 10373ed to b8894bd Compare October 29, 2021 19:33
@lmm lmm merged commit f111f7f into projectcalico:master Oct 29, 2021
@lmm lmm deleted the lmm-calico-windows-upgrade-image branch October 29, 2021 21:58
lmm added a commit to lmm/node that referenced this pull request Oct 29, 2021
* Add building of calico windows upgrade image
lmm added a commit that referenced this pull request Nov 1, 2021
* Add building of calico windows upgrade image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants