Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for +/- context nav via Microsoft Edge browsers. Display the c… #1011

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

seanaery
Copy link
Contributor

…hild nodes and toggle the icon. Fixes #1009.

@seanaery seanaery force-pushed the 1009-bugfix-ms-edge-navigation branch from b4f45d7 to 1daa042 Compare August 26, 2020 15:02
@seanaery
Copy link
Contributor Author

A couple minor bugs were preventing MS Edge from working. Edge was interpreting e.target to be the +/- svg; using e.currentTarget instead consistently finds the link element whose click event listener fired. The content CSS property only works consistently with the ::before and ::after pseudo-elements across-browser, so Edge wasn't toggling the +/-. I also removed the hard-coded + icon from the view, leaving it up to the CSS rule to render, which it now does consistently.

Copy link
Contributor

@jkeck jkeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @seanaery! Sorry this took so long to get 👀 on. Doing some build fixes/ rails compatibility updates and wanted to make sure this got in too.

@jkeck jkeck merged commit b05bbc6 into master Jan 5, 2021
@jkeck jkeck deleted the 1009-bugfix-ms-edge-navigation branch January 5, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

+/- context navigation doesn't work in Microsoft Edge
2 participants