Removed compilator warnings #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have a good day, changes were accomplished in order to solve some compilation warnings. |
ppwwyyxx
reviewed
Sep 8, 2020
src/feature/gaussian.hh
Outdated
| @@ -9,101 +9,116 @@ | |||
| #include "lib/utils.hh" | |||
| #include "lib/timer.hh" | |||
| #include "common/common.hh" | |||
| namespace pano { | |||
| namespace pano | |||
| { | |||
There was a problem hiding this comment.
most of this PR are not related to compiler warnings
There was a problem hiding this comment.
Have a good day, automatic re-indentation process was accomplished by my IDE, I am disabling it in order to change the correct lines only.
There was a problem hiding this comment.
Comments added on really helpful changes.
sisco0
commented
Sep 8, 2020
src/lib/geometry.hh
Outdated
|
|
||
| constexpr explicit Vector(T m_x = 0, T m_y = 0, T m_z = 0) : x(m_x), y(m_y), z(m_z) {} | ||
|
|
||
| constexpr Vector(const Vector<T> &rhs) = default; |
sisco0
commented
Sep 8, 2020
| T *dest = ret.ptr(i); | ||
| memcpy(cur_line, dest, sizeof(T) * w); | ||
| { // pad the border | ||
| memcpy((void *)cur_line, (void *)dest, sizeof(T) * w); |
|
Have a good day, fixes have been applied without re-indentation of the code. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compilator warnings were removed, same as shown at issue #107