fix HTML filter issue when the text contains malformed HTML tags (mek…

…ras#27)
pozsi · Aug 20, 2020 · 80b3504 · 80b3504
1 parent a358650
commit 80b3504
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/Source/Filter/HtmlFilter.php b/src/Source/Filter/HtmlFilter.php
@@ -120,7 +120,7 @@ public function filter(string $string): string
                 case '>' === $char:
                     if ($this->isIgnoredTag($tagName)) {
                         $ignoreTagContent = true;
-                    } elseif ('/' === $tagName[0]) {
+                    } elseif ($tagName === null || '/' === $tagName[0]) {
                         $ignoreTagContent = false; // Restore to default state.
                     }
                     $context = self::CTX_TAG_CONTENT;
@@ -258,6 +258,10 @@ function ($match) {
      */
     private function isIgnoredTag(?string $name): bool
     {
+        if ($name === null) {
+            return false;
+        }
+
         foreach (self::$ignoreTags as $tag) {
             if (strcasecmp($tag, $name) === 0) {
                 return true;

diff --git a/tests/Unit/Source/Filter/HtmlFilterTest.php b/tests/Unit/Source/Filter/HtmlFilterTest.php
@@ -90,4 +90,12 @@ public function testMalformedAttribute(): void
         $text = '           test    ';
         static::assertEquals($text, $filter->filter($html));
     }
+
+    public function testMalformedTags(): void
+    {
+        $filter = new HtmlFilter();
+        $html = "foo/>bar<br><br/>";
+        $text = "foo/ bar         ";
+        static::assertEquals($text, $filter->filter($html));
+    }
 }