Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field access in PIL #1586

Draft
wants to merge 95 commits into
base: main
Choose a base branch
from
Draft

Field access in PIL #1586

wants to merge 95 commits into from

Conversation

gzanitti
Copy link
Collaborator

This RP adds field access to PIL. At the moment, they are only valid for accessing fields within structs.
It goes on top of PR #1516 which implements structs, so that one should be reviewed first.

@gzanitti
StructDeclaration & auxiliary functions (display, children, etc.)
bf13c94
@gzanitti
Display, TypeDeclaration, TypeConstructor, etc.
81694ee
@gzanitti
Basic struct declaration
67bdbc0
@gzanitti
Temporarily using SelectedExpression with "$" instead of "*" to avoid…
f46673c 
… conflicts
@gzanitti
WIP
582d95c
@gzanitti
Patterns
668ed89
@gzanitti
Functions as struct fields type & test
b6e4d3f
@gzanitti
missed clippy deny
f21eeaa
@gzanitti
Ellipsis in StructPattern, and missed case in handle_statement
ed196cf
@gzanitti
WIP
585ca0c
@gzanitti
Merge remote-tracking branch 'upstream/main' into structs_in_pil
df3aec3
@gzanitti
WIP
877a828
@gzanitti
Main merged
8235873
@gzanitti
Main merged
4cc6f1c
@gzanitti
Main marged with new grammar
303ffa2
@gzanitti
Updated grammar: Conflict with new StructExpression
47022a3
@gzanitti
StructExpression needs to be redefine
46e06e4
@gzanitti
//StructExpression
81051e9
@gzanitti
//StructExpression
fb4e357
@gzanitti
Temporarily resolving the grammar with X?{ .. }
bf8f2de
@gzanitti
Basic type inference (fake grammar)
70bc1fc
@gzanitti
Fields are going to be a problem 🫠
18fea1a
@gzanitti
More tests
df3abd4
@gzanitti
Merge remote-tracking branch 'upstream/main' into structs_in_pil
d2d3992
@gzanitti
Structs integration
0a23ec5
@gzanitti
Conflict solved & Struct pattern updated
c4d535f
@gzanitti
Test fixed
6290bf8
@gzanitti
FieldAccess
008a61d
@gzanitti
Parsing
7d0dbeb
@gzanitti
Progress in type inference & new test
08dccea
@gzanitti gzanitti mentioned this pull request Jul 25, 2024
Draft
@gzanitti
Conflict solved
d0ca0f7
@gzanitti
Conflicts & new tests organization
f442d47
@gzanitti
Conflicts & new tests organization
2b1b5a4
@gzanitti
Minor fix
8b8211b
@gzanitti
Missed param after merge
ff2b7b6
@gzanitti
Main merged
89fac56
@gzanitti
More fixes
f375e19
@gzanitti
Path fixed
ca41e60
@gzanitti
Main merged
34c7b11
@gzanitti
path fixed
23647c2
@gzanitti
Error msg
41a62d9
@gzanitti
Minor fixes
05be960
@gzanitti
Cleaner code
00efbf0
@gzanitti
Merged new grammar. keyword with removed from struct instanciation
a96d489
@gzanitti
Merged new grammar. keyword with removed from struct instanciation
9ca8d93
@gzanitti
Fixed grammar: removed RestrictedExpression from MatchArm
f2c298c
@gzanitti
Fixed grammar: removed RestrictedExpression from MatchArm
7317c5f
@gzanitti
conflicts solved
e59a4f1
@gzanitti
children() separation from namedexpressions
992c018
@gzanitti
Grammar (NamedExpression<Box<...>>) and new method not implemented fo…
9fad753 
…r structs
@gzanitti
missed match arm implemented
e809301
@gzanitti
remove parenthesis outside lambda functions in struct tests
612622f
@gzanitti
Check and negative tests for wrong field names
7e37b0c
@gzanitti
More checks and tests
3ada7db
@gzanitti
Fix tests with undefined structs or fields
0308859
@gzanitti
Minor improvements
6bdf680
@gzanitti
cleaner statement processor
754ac64
@gzanitti
arc
f7393d6
@gzanitti
conflicts
d5b8983
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gzanitti