Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change wording for country options #405

Merged
merged 7 commits into from
Jul 26, 2021
Merged

Change wording for country options #405

merged 7 commits into from
Jul 26, 2021

Conversation

florianbrinkmann
Copy link
Member

Fixes #400

This PR changes the wording for the country options to country_allowed and country_denied. The migration runs:

  • when the plugin is updated normally via the upgrade mechanism (I think we cannot test that before the release, sadly…)
  • when the plugin is updated via ZIP upload
  • when the new version of the plugin is installed via FTP or so, the migration runs when the ASB options page is visited

@florianbrinkmann
Copy link
Member Author

florianbrinkmann commented Jul 8, 2021 •
edited
Loading

What needs to be tested (with one of the ways described in the PR description above):

  • is the antispambee_db_version correctly upgraded to 1.02
  • are the option names country_white and country_black changed to country_allowed and country_denied in the db and the values correctly migrated

pfefferle
pfefferle approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@pfefferle pfefferle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@florianbrinkmann
Copy link
Member Author

florianbrinkmann commented Jul 22, 2021 •
edited
Loading

  • Update @change version numbers to 2.10.0

pfefferle
pfefferle reviewed Jul 22, 2021
View reviewed changes
antispam_bee.php Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 23, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@florianbrinkmann florianbrinkmann merged commit d4b4777 into master Jul 26, 2021
@florianbrinkmann florianbrinkmann deleted the change-wording-for-options branch July 26, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfefferle pfefferle pfefferle approved these changes

@2ndkauboy 2ndkauboy Awaiting requested review from 2ndkauboy

@krafit krafit Awaiting requested review from krafit

@Zodiac1978 Zodiac1978 Awaiting requested review from Zodiac1978

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change wording for IP address lists
2 participants
@florianbrinkmann @pfefferle