Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ticklabelposition for cartesian subplots and colorbars #5275

Merged
merged 52 commits into from
Dec 2, 2020
Merged

Implement ticklabelposition for cartesian subplots and colorbars #5275

merged 52 commits into from
Dec 2, 2020

Commits on Nov 13, 2020

  1. declare calcBreaksLength once

    @archmoj
    archmoj committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    4da7e58 View commit details
    Browse the repository at this point in the history

  2. refactor inside and outside ticks

    @archmoj
    archmoj committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    3ea0bb7 View commit details
    Browse the repository at this point in the history

  3. fix issue 5262

    @archmoj
    archmoj committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    c7a23b4 View commit details
    Browse the repository at this point in the history

  4. rename axes.makeTransFn to makeTransTickFn

    @archmoj
    archmoj committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    a9d9140 View commit details
    Browse the repository at this point in the history

  5. rename transFn function in cartesian axes

    @archmoj
    archmoj committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    ee2d648 View commit details
    Browse the repository at this point in the history

  6. create makeTransTickLabelFn and handle period case inside it

    @archmoj
    archmoj committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    fa07cc5 View commit details
    Browse the repository at this point in the history

  7. implement ticklabelposition for cartesian axes

    @archmoj
    archmoj committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    9e63c04 View commit details
    Browse the repository at this point in the history

  8. add image tests

    @archmoj
    archmoj committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    7a6fd0f View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2020

  1. store and use ticklabel bounding boxes to increase pad for inside labels

    @archmoj
    archmoj committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    c262d4b View commit details
    Browse the repository at this point in the history

  2. autorange call to account extra pad for inside tick labels

    @archmoj
    archmoj committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    74f594d View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2020

  1. save initial ranges after insideticklabel is done

    @archmoj
    archmoj committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    5ca95d3 View commit details
    Browse the repository at this point in the history

  2. better fit based on tick angle - increase pad only when text does not… 

    … fit inside
    @archmoj
    archmoj committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    8a34a95 View commit details
    Browse the repository at this point in the history

  3. ensure plotinfo in axes redraw

    @archmoj
    archmoj committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    22e9519 View commit details
    Browse the repository at this point in the history

  4. reset autorange flag for inside tick labels during GUI edits

    @archmoj
    archmoj committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    95751cb View commit details
    Browse the repository at this point in the history

  5. fixup interactions

    @archmoj
    archmoj committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    ab37122 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2020

  1. Merge remote-tracking branch 'origin/master' into ticklabelposition 

     - and resolve conflict in src/plots/cartesian/constraints.js
    @archmoj
    archmoj committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    432e448 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2020

  1. update attribute description 

    Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
    @archmoj @alexcjohnson
    archmoj and alexcjohnson committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    e840f8f View commit details
    Browse the repository at this point in the history

  2. revise ticklabelposition supply defaults

    @archmoj
    archmoj committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    2361958 View commit details
    Browse the repository at this point in the history

  3. validate new scaleanchor matches mocks

    @archmoj
    archmoj committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    91ea2f6 View commit details
    Browse the repository at this point in the history

  4. hide out of range inside text labels during redraws

    @archmoj
    archmoj committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    47c5773 View commit details
    Browse the repository at this point in the history

  5. adjust padding for inside tick labels

    @archmoj
    archmoj committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    591b321 View commit details
    Browse the repository at this point in the history

  6. improve overlap detection for aligned tick labels

    @archmoj
    archmoj committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    bd379f8 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2020

  1. use lib function to convert from deg to rad

    @archmoj
    archmoj committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    05893b3 View commit details
    Browse the repository at this point in the history

  2. revisit ticklabelposition logic

    @archmoj
    archmoj committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    b5f09fb View commit details
    Browse the repository at this point in the history

  3. fix issue 5301

    @archmoj
    archmoj committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    6e80dc9 View commit details
    Browse the repository at this point in the history

  4. fixups u and v

    @archmoj
    archmoj committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    21b59e4 View commit details
    Browse the repository at this point in the history

  5. correct linewidth effect

    @archmoj
    archmoj committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    e01dc32 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2020

  1. fixup tickangle for inside tick labels

    @archmoj
    archmoj committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    b46327c View commit details
    Browse the repository at this point in the history

  2. handle multi-line dates on x-axis

    @archmoj
    archmoj committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    aa57518 View commit details
    Browse the repository at this point in the history

  3. adjust pad for inside labels and make more room for end labels to appear

    @archmoj
    archmoj committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    70e708a View commit details
    Browse the repository at this point in the history

  4. validate new mocks

    @archmoj
    archmoj committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    fa0f3b2 View commit details
    Browse the repository at this point in the history

  5. add jsamine tests for ticklabelposition defaults

    @archmoj
    archmoj committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    c87cda6 View commit details
    Browse the repository at this point in the history

  6. clear function to hide inside tick labels and ensure subplot

    @archmoj
    archmoj committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    c59fcd9 View commit details
    Browse the repository at this point in the history

  7. simplify reading axis end positions to hide inside tick labels

    @archmoj
    archmoj committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    d2c656d View commit details
    Browse the repository at this point in the history

  8. ensure ax._rl in hide function

    @archmoj
    archmoj committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    d7423af View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2020

  1. compute linear range if not defined

    @archmoj
    archmoj committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    60addca View commit details
    Browse the repository at this point in the history

  2. add ticklabelposition option to colorbar

    @archmoj
    archmoj committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    a83d5af View commit details
    Browse the repository at this point in the history

  3. add inside and outside ticklabelposition options to mocks

    @archmoj
    archmoj committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    01efcf5 View commit details
    Browse the repository at this point in the history

  4. use fresh linear range in the hide function

    @archmoj
    archmoj committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    5244a09 View commit details
    Browse the repository at this point in the history

  5. add image test for issue 5301 - and before fixing another bug on the … 

    …x axes
    @archmoj
    archmoj committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    a7518ec View commit details
    Browse the repository at this point in the history

  6. adjust vertical ticklabels on x axes

    @archmoj
    archmoj committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    8efa7bd View commit details
    Browse the repository at this point in the history

  7. revisit positioning of inside tick labels after bug fix

    @archmoj
    archmoj committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    2ff6cfb View commit details
    Browse the repository at this point in the history

  8. test another angle on the mock

    @archmoj
    archmoj committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    2108c8d View commit details
    Browse the repository at this point in the history

  9. adjustment for vertical tick labels inside

    @archmoj
    archmoj committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    a1d021b View commit details
    Browse the repository at this point in the history

  10. adjustment for vertical labels on the x axis and update baselines

    @archmoj
    archmoj committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    6f575a3 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2020

  1. remove duplicate pad functions

    @archmoj
    archmoj committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    0e52adb View commit details
    Browse the repository at this point in the history

  2. revert guiEdit and fixup autorange interactions for inside tick labels

    @archmoj
    archmoj committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    999f877 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2020

  1. revise axId scope

    @archmoj
    archmoj committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    7b22175 View commit details
    Browse the repository at this point in the history

  2. fixup autorange on interactions

    @archmoj
    archmoj committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    445eee4 View commit details
    Browse the repository at this point in the history

  3. consider some offset from top of the bounding box when hiding a horiz… 

    …ontal label
    @archmoj
    archmoj committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    5f252f5 View commit details
    Browse the repository at this point in the history

  4. adjust position on bar_multiline_labels mock

    @archmoj
    archmoj committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    90c3097 View commit details
    Browse the repository at this point in the history

  5. add comment about U and V

    @archmoj
    archmoj committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    40c09b7 View commit details
    Browse the repository at this point in the history