Fix colorbar templating for "non-root" colorscales #4470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- propagate template info into colorscale container - fix marker_colorscale_template baseline which was botched from 6a47d66
etpinard
commented
Jan 7, 2020
| @@ -101,6 +101,7 @@ if(allMock || argv.filter) { | |||
| } | |||
|
|
|||
| var FLAKY_LIST = [ | |||
| 'treemap_coffee', | |||
There was a problem hiding this comment.
cc @archmoj something is off with this new mock. See https://circleci.com/gh/plotly/plotly.js/64411?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link - it failed 5 times in a row.
There was a problem hiding this comment.
You can pick 0175108 to fix that.
|
Thank you! |
|
Thanks for the quick turnaround @etpinard! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4467
before: https://codepen.io/etpinard/pen/ZEYrLdo
after: https://codepen.io/etpinard/pen/zYxRNVm (
colorbar.ypadnow works)cc @archmoj @wbrgss