Bump mapbox-gl to v1.3.2 #4230
Bump mapbox-gl to v1.3.2 #4230
Conversation
... to workaround a mapbox-gl bug introduced in 1.3.0
|
Note that This means that we could implement a way to plot multiple mapbox subplots with different mapbox access token on the same plotly.js graph. |
| // | ||
| // Need a 10ms delay (0ms should suffice to skip a thread in the | ||
| // render loop) to workaround mapbox-gl bug introduced in v1.3.0 | ||
| setTimeout(resolve, 10); |
There was a problem hiding this comment.
@archmoj w/o this extra 10ms delay, call sequences like
// off the `mapbox_0` mock
Plotly.restyle(gd, 'visible', false)
.then(() => Plotly.restyle(gd, 'visible', true))
.then(() => Plotly.restyle(gd, 'visible', 'legendonly', [1]))fails and logs
I suspect this is caused by mapbox/mapbox-gl-js#8633 - but I haven't investigated further.
There was a problem hiding this comment.
OK. I'll leave this conversation open so that it is noticed by in the QA.
|
Looks like we'll also need 422d5d3 to make Let's wait a little bit before. Ideally, I would merge master into this branch after #4219 gets merged. |
|
@etpinard thanks very much for the PR. |
mostly to fix https://github.com/plotly/plotly.js/network/alert/package-lock.json/esm/open
See what's next in mapbox-gl since the last version bump we made:
cc @archmoj