Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates d3-sankey-circular to 0.33.0 #3611

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Conversation

RussGlover
Copy link

Fixes #3610

@etpinard
Copy link
Contributor

etpinard commented Mar 6, 2019

Thanks very much for the PR!

That package-lock.json shows a nasty diff. Which npm version are you using? Could you try to generate the package-lock.json again using npm@6.8.0? Thank you!

@RussGlover
Copy link
Author

Oops I use yarn usually, didn't think to check about npm version. I'll do that.

@RussGlover
Copy link
Author

Okay I fixed it, only 7 line diff for package-lock.json now! I went a pretty roundabout way to revert the old commit and had to force push it. Let me know if there is anything else I need to do. Thanks for the quick response!

package-lock.json Outdated Show resolved Hide resolved
@antoinerg
Copy link
Contributor

@etpinard I checked the changes upstream and this is good to go. I will let you give the dancer or merge.

@RussGlover thanks again :)

@etpinard
Copy link
Contributor

etpinard commented Mar 7, 2019

💃

@etpinard etpinard added bug something broken status: reviewable labels Mar 7, 2019
@antoinerg antoinerg merged commit bf913e6 into plotly:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants