This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Deps update 20210630 #194
Merged
Deps update 20210630 #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(elements.txt is already committed)
alexcjohnson
commented
Jul 1, 2021
alexcjohnson
force-pushed
the
deps-update-20210630
branch
from
0331a47
to
ad6702f
Compare
eff-kay
reviewed
Jul 8, 2021
|
LTGM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from regular dep updates:
attributes.jsonto the repo so we'll see changes pulled from MDN more explicitly. Until we do this we don't actually know whether we've been adding or removing props from specific elements. We do know however that we're not adding or removing any entire elements.webpack-serveas a dep. I don't think we're actually using it anywhere anymore, and in fact it's deprecated at this point in favor of just doing the same through regular webpack config.