Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Document discouraged elements, and fix ObjectEl data #178

Merged
merged 7 commits into from
Jan 30, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move percy to py37 and separate out finalize step
  • Loading branch information
alexcjohnson committed Jan 30, 2021
commit 72796c48e3dc7bb1999ef47f9adb6d2f81e6e04a
16 changes: 14 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
version: 2

jobs:
percy-finalize:
docker:
- image: percyio/agent
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
steps:
- run: percy finalize --all

python-2.7: &test-template
docker:
- image: circleci/python:2.7-stretch-node-browsers
Expand All @@ -9,7 +18,7 @@ jobs:
password: $DASH_PAT_DOCKERHUB
environment:
PYTHON_VERSION: py27
PERCY_ENABLE: 1
PERCY_ENABLE: 0

working_directory: ~/repo

Expand Down Expand Up @@ -76,7 +85,7 @@ jobs:
password: $DASH_PAT_DOCKERHUB
environment:
PYTHON_VERSION: py37
PERCY_ENABLE: 0
PERCY_ENABLE: 1

workflows:
version: 2
Expand All @@ -85,3 +94,6 @@ workflows:
- python-2.7
- python-3.6
- python-3.7
- percy-finalize:
requires:
- python-3.7
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"postbuild": "es-check es5 dash_html_components/*.js",
"build:watch": "watch 'npm run build' src",
"test:import": "python -m unittest tests.test_dash_import",
"test:py": "pytest tests/test_dash_html_components.py tests/test_integration.py",
"test:py": "pytest --nopercyfinalize tests/test_dash_html_components.py tests/test_integration.py",
"test": "run-s -c test:py test:import lint"
},
"author": "Chris Parmer <chris@plotly.com>",
Expand Down