Plotlyjs 1.49.0 upgrade #589
Conversation
shammamah-zz
force-pushed
the
plotlyjs-1.49.0-upgrade
branch
from
88cae8d
to
a32ef72
Compare
There was a problem hiding this comment.
@shammamah Nice catch cleaning the old ones out of inst/deps before any more pile up! 💃
@rpkyle Let's push this through now for the current update to get properly applied, but should we be emptying out that dir during package generation, before refilling it with files found from the Python side? Is there ever a case we need to leave something in that dir that's not found in Python? Please make an issue in the dash repo to follow up on this. Then hopefully future plotly.js updates here can leave inst/deps alone, and it will be updated during the release process.
|
(oh looks like there's a new config option that needs propagating to the component props... anyway the 💃 stands once you get tests to pass) |
src/components/Graph.react.js
Outdated
| /** | ||
| * Delay for registering a double-click event in ms | ||
| */ | ||
| doubleClickDelay: PropTypes.number, |
There was a problem hiding this comment.
@Marc-Andre-Rivet The prop in plotly.js has min/max values defined, but I don't think there's a way to do that here. Should I add the min/max values to the docstring?
There was a problem hiding this comment.
You're right. Proptypes support runtime validation but our use of react-docgen does not. The docstring is best. :)
shammamah-zz
force-pushed
the
plotlyjs-1.49.0-upgrade
branch
from
a43dfc8
to
7c97515
Compare
Add auto-generated files. Update CHANGELOG. Add link to PR. Revert "Add auto-generated files." This reverts commit 1a34c46. Update external and local package locations. Update CONTRIBUTING.md. Remove old plotly.js dependency files. feature summary for plotly.js 1.49 Add config options from plotly.js 1.49.0 release. doubleClickDelay and showEditInChartStudio. Add information about defaults and min/max to new props. Update CHANGELOG.md Co-Authored-By: Marc-André Rivet <Marc-Andre-Rivet@users.noreply.github.com> Fix formatting.
shammamah-zz
force-pushed
the
plotlyjs-1.49.0-upgrade
branch
from
87effe5
to
7afc9aa
Compare
|
Closes #577