-
-
Notifications
You must be signed in to change notification settings - Fork 146
DatePickerSingle prop typos #361
DatePickerSingle prop typos #361
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
💃 |
@tcbegley I see this PR has been sitting here for a few weeks now. All that's missing is a merge from master. Do you want to bring it through the finish line or can we do it ourselves? Whatever your preference, thanks for your contribution! 😄 |
Hey @Marc-Andre-Rivet, sorry, I had been meaning to chase this up actually. I don't have permission to merge, so please do go ahead and merge for me. What's your preferred way of resolving the conflicts? I can rebase and rebuild, or maybe the bundles don't even really need to be included in this PR anyway? Let me know if you want me to sort it out before merging. |
@tcbegley The contribution guideline is missing a few key points that were not raised during the review. What's needed:
If you'd rather I do the changes in the fork I'm more than willing too. Don't hesitate if you have additional questions. |
@Marc-Andre-Rivet That makes sense, happy to take a pass at that now and push for you to review. |
@tcbegley Sorry if this follow up is a bit haphazard, this is the first community PR I pick up here 😧 |
@Marc-Andre-Rivet no worries at all! You've been very helpful so far. I've made the changes you suggested (with the exception of bumping to |
@tcbegley Yup, 0.40.5 is where it's at. There was a visual diff but it was not significant. Will squash and merge and follow up with the publish in a short while. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
I was wondering about that. I'm guessing to do with the fact that Anyway, thanks for the help and for merging! |
This simple PR corrects a couple of typos in props being passed to
SingleDatePicker
fromreact-dates
inside the definition ofDatePickerSingle
.See here and here
In particular this means the
show_outside_days
prop ofDatePickerSingle
fromdash-core-components
has the desired effect.