This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Serve unminified bundle support #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💃 I had that percy issue before, I think it goes away when you rebase. Can you do that before merging to make sure? |
T4rk1n
force-pushed
the
serve-unminified
branch
from
84d63c4
to
8dff0bf
Compare
|
Renamed the bundles plotly/dash#384 |
T4rk1n
force-pushed
the
serve-unminified
branch
from
8dff0bf
to
43924f0
Compare
|
@valentijnnieman Can you look at the percy diff ? I rebased on master an hour ago and it looks like there is a regression in the tabs. |
|
@T4rk1n Looks like the Graph is rendered differently with the new version of plotly.js, looks better to me :-) |
|
@T4rk1n Percy is being a little bit difficult lately it seems... Feels like the snapshots are changing slightly every time it runs. Maybe if we replace the tests with the Selenium WaitAPI instead of the time.sleep() it will be more stable? |
|
@valentijnnieman Yea, I think you can go ahead with the Selenium WaitAPI if you have the time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
build:js-devcommand and support in_js_dist.plotly/dash#369