Clear trace response instead of metric response in OTelExportSinkNode::ConsumeSpans
#1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…move duplicate return in OTelModule::Init Signed-off-by: Benjamin Kilimnik <bkilimnik@pixielabs.ai>
vihangm
reviewed
May 20, 2024
vihangm
approved these changes
Jul 24, 2024
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Jul 26, 2024
…tSinkNode::ConsumeSpans` (pixie-io#1910)" This reverts commit 970a54a.
ddelnano
added a commit
that referenced
this pull request
Jul 28, 2024
…se members (#1975) Summary: Add test to verify that ConsumeMetrics and ConsumeTraces clear response members This adds test coverage for the bug fix in #1910. This is a follow up to the conversation [here](#1910 (comment)) Relevant Issues: N/A Type of change: /kind bug Test Plan: Verified that unit test fails if #1910 is reverted ``` $ git show HEAD commit 4ab4a9c (HEAD -> ddelnano/add-tests-for-otel-sink-bug, ddelnano/ddelnano/add-tests-for-otel-sink-bug) Author: Dom Del Nano <ddelnano@gmail.com> Date: Fri Jul 26 12:17:00 2024 +0000 Revert "Clear trace response instead of metric response in `OTelExportSinkNode::ConsumeSpans` (#1910)" This reverts commit 970a54a. $ bazel test src/carnot/exec:otel_export_sink_node_test --test_output=all [ ... ] [ RUN ] OTelExportSinkNodeTest.consume_spans_clears_span_responses src/carnot/exec/otel_export_sink_node_test.cc:1748: Failure Value of: response->partial_success().rejected_spans() == 0 Actual: false Expected: true ``` --------- Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Addresses a couple of small-ish bugs
ConsumeSpansis mistakenly clearing themetrics_response_(which is used inConsumeMetrics) instead of thetrace_response_.OTelModule::Init.Type of change: /kind bug
Test Plan: CI, skaffold-ed standalone pem and ran OTel export scripts