Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the BPF test for Mongo protocol tracing #1778

Merged
merged 8 commits into from
Dec 6, 2023

Conversation

kpattaswamy
Copy link
Member

@kpattaswamy kpattaswamy commented Nov 21, 2023

Summary: This PR adds the BPF test for the mongo protocol tracer. The default tracing mode is on.

Related issues: #640

Type of change: /kind feature

Test Plan: Added the BPF test

Changelog Message:

MongoDB query profiling is now supported by Stirling.

Copy link
Member

@ddelnano ddelnano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm once the license check issue is figured out.

@kpattaswamy kpattaswamy marked this pull request as ready for review November 30, 2023 18:51
@ddelnano
Copy link
Member

@kpattaswamy since this is the PR that will complete Mongo db tracing functionality, can we add the Changelog Message: field?

Signed-off-by: Kartik Pattaswamy <kpattaswamy@pixielabs.ai>
Signed-off-by: Kartik Pattaswamy <kpattaswamy@pixielabs.ai>
Signed-off-by: Kartik Pattaswamy <kpattaswamy@pixielabs.ai>
…d on older kernels in the test infra

Signed-off-by: Kartik Pattaswamy <kpattaswamy@pixielabs.ai>
Signed-off-by: Kartik Pattaswamy <kpattaswamy@pixielabs.ai>
Signed-off-by: Kartik Pattaswamy <kpattaswamy@pixielabs.ai>
Signed-off-by: Kartik Pattaswamy <kpattaswamy@pixielabs.ai>
Signed-off-by: Kartik Pattaswamy <kpattaswamy@pixielabs.ai>
Copy link
Member

@vihangm vihangm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License is ISC which is on the approved list. https://github.com/cncf/foundation/blob/main/allowed-third-party-license-policy.md

It's just the checker failing to detect it.

@vihangm vihangm merged commit 0e6ef3e into pixie-io:main Dec 6, 2023
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants