Update buffer position when returning kIgnored #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Ignored Signed-off-by: Kartik Pattaswamy <kpattaswamy@pixielabs.ai>
kpattaswamy
changed the title
ddelnano
reviewed
Nov 2, 2023
Comment on lines
68
to
69
| if (!(frame_type == Type::kOPMsg || frame_type == Type::kOPCompressed || | ||
| frame_type == Type::kReserved)) { |
There was a problem hiding this comment.
Can we remove Type::kReserved and Type::kOPCompressed from this if statement to avoid adding the else if branch added in this PR?
I ran the updated unit test and it seems to pass still.
There was a problem hiding this comment.
Will modify the comment as well
Signed-off-by: Kartik Pattaswamy <kpattaswamy@pixielabs.ai>
ddelnano
approved these changes
Nov 2, 2023
aimichelle
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This PR removes the frame's contents from the buffer in the case we return
kIgnoredwhen the frame is a type (opcode) we do not parse. When running the BPF test we noticed that the program would stall when the parser encountered a frame with an opcode it does not support. This was due to to the parser returningkIgnoredtoParseFramesLoopand it not moving the buffer forward before callingParseFrameagain. This change will update the buffer position before returningkIgnoredtoParseFramesLoopso that the remaining frames in the buffer can be parsed.Related issues: #640
Type of change: /kind bug
Test Plan: Modified the existing test checking for the unsupported opcode type.