Add support to stitch MongoDB frames #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddelnano
reviewed
Oct 20, 2023
src/stirling/source_connectors/socket_tracer/protocols/mongodb/stitcher.cc
Outdated
Show resolved
Hide resolved
src/stirling/source_connectors/socket_tracer/protocols/mongodb/stitcher.cc
Outdated
Show resolved
Hide resolved
src/stirling/source_connectors/socket_tracer/protocols/mongodb/stitcher_test.cc
Show resolved
Hide resolved
src/stirling/source_connectors/socket_tracer/protocols/mongodb/stitcher.cc
Outdated
Show resolved
Hide resolved
src/stirling/source_connectors/socket_tracer/protocols/mongodb/stitcher.cc
Outdated
Show resolved
Hide resolved
src/stirling/source_connectors/socket_tracer/protocols/mongodb/stitcher_test.cc
Outdated
Show resolved
Hide resolved
src/stirling/source_connectors/socket_tracer/protocols/mongodb/stitcher_test.cc
Outdated
Show resolved
Hide resolved
src/stirling/source_connectors/socket_tracer/protocols/mongodb/stitcher.cc
Outdated
Show resolved
Hide resolved
kpattaswamy
force-pushed
the
mongodb-stitching-state-ordering
branch
from
d36f291
to
bb1abcd
Compare
ddelnano
reviewed
Oct 24, 2023
src/stirling/source_connectors/socket_tracer/protocols/mongodb/stitcher.cc
Outdated
Show resolved
Hide resolved
ddelnano
reviewed
Oct 24, 2023
src/stirling/source_connectors/socket_tracer/protocols/mongodb/stitcher.cc
Outdated
Show resolved
Hide resolved
kpattaswamy
force-pushed
the
mongodb-stitching-state-ordering
branch
from
d4a0c1c
to
92e0ef3
Compare
etep
reviewed
Oct 30, 2023
src/stirling/source_connectors/socket_tracer/protocols/mongodb/stitcher.cc
Outdated
Show resolved
Hide resolved
etep
approved these changes
Oct 31, 2023
kpattaswamy
force-pushed
the
mongodb-stitching-state-ordering
branch
from
412d725
to
3ea7ca8
Compare
Signed-off-by: Kartik Pattaswamy <kpattaswamy@pixielabs.ai>
Signed-off-by: Kartik Pattaswamy <kpattaswamy@pixielabs.ai>
Signed-off-by: Kartik Pattaswamy <kpattaswamy@pixielabs.ai>
Signed-off-by: Kartik Pattaswamy <kpattaswamy@pixielabs.ai>
Signed-off-by: Kartik Pattaswamy <kpattaswamy@pixielabs.ai>
Signed-off-by: Kartik Pattaswamy <kpattaswamy@pixielabs.ai>
Signed-off-by: Kartik Pattaswamy <kpattaswamy@pixielabs.ai>
kpattaswamy
force-pushed
the
mongodb-stitching-state-ordering
branch
from
3ea7ca8
to
57faa96
Compare
JamesMBartlett
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This PR adds functionality to stitch MongoDB frames together. It relies on state to iterate over the order of streamIDs parsed and uses a response led matching approach.
Related issues: #640
Type of change: /kind feature
Test Plan: Added tests