Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transceivers state change from inactive to active #2426

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zjzhang-cn
Copy link
Member

Description

Reuse transceivers in remote peer。

In the existing RTC Transceivers, when the state of the remote transceiver changes from inactive to active, the state of the pion also needs to change from inactive to active。

Reference issue

Fixes #...

…anges from inactive to active, the state of the pion also needs to change from inactive to active
@codecov
Copy link

codecov bot commented Feb 25, 2023

Codecov Report

Patch coverage: 34.21% and project coverage change: -0.08 ⚠️

Comparison is base (61f69be) 77.52% compared to head (cc4f788) 77.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2426      +/-   ##
==========================================
- Coverage   77.52%   77.45%   -0.08%     
==========================================
  Files          87       87              
  Lines        9294     9358      +64     
==========================================
+ Hits         7205     7248      +43     
- Misses       1654     1680      +26     
+ Partials      435      430       -5     
Flag Coverage Δ
go 79.19% <34.21%> (-0.10%) ⬇️
wasm 70.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
peerconnection.go 76.99% <34.21%> (-1.11%) ⬇️

... and 86 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cnderrauber
Copy link
Member

Thank you for refining this, can you add a test case for this?

@zjzhang-cn
Copy link
Member Author

zjzhang-cn commented Mar 3, 2023

Client peer cooperation is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants