Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Color: Add design tokens package and color page (#1616) #1627

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

AlbertCarreras
Copy link
Contributor

@AlbertCarreras AlbertCarreras commented Aug 16, 2021

Summary

Error introduced that needs to be fixed
image

image

gestalt-design-tokens
this is what’s inside the package
image

but then this import wouldn’t exist

image

image

image

PR here for reference: https://phabricator.pinadmin.com/D767767

Links

  • [Jira](link to Jira ticket(s))
  • [TDD](link to Paper doc)
  • [Figma](link to Figma file)

Checklist

  • Added unit and Flow Tests
  • Added documentation + accessibility tests
  • Verified accessibility: keyboard & screen reader interaction
  • Checked dark mode, responsiveness, and right-to-left support
  • Checked stakeholder feedback (e.g. Gestalt designers)

@AlbertCarreras AlbertCarreras requested a review from a team as a code owner August 16, 2021 20:39
@AlbertCarreras AlbertCarreras added the major release Major release label Aug 16, 2021
@netlify
Copy link

netlify bot commented Aug 16, 2021

✔️ Deploy Preview for gestalt ready!

🔨 Explore the source changes: af5f6fe

🔍 Inspect the deploy log: https://app.netlify.com/sites/gestalt/deploys/611acd1b14df4e0007dbbc96

😎 Browse the preview: https://deploy-preview-1627--gestalt.netlify.app/

@AlbertCarreras AlbertCarreras merged commit 053bf71 into pinterest:master Aug 16, 2021
@liuyenwei
Copy link
Contributor

FYI, the error that we were seeing when trying to build was Error: "null" or "undefined" thrown
image

ayeshakmaz added a commit that referenced this pull request Aug 18, 2021
@AlbertCarreras AlbertCarreras deleted the revert branch September 20, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major release Major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants