Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable: remove tidb_ddl_reorg_worker_cnt and tidb_ddl_reorg_batch_size session level. #8941

Merged
merged 12 commits into from
Jan 10, 2019

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Jan 4, 2019

What problem does this PR solve?

tidb_ddl_reorg_worker_cnt, tidb_ddl_reorg_batch_size is only take effect in DDL owner server. It meaningless for the session variable. So I remove the session level and only keep the global level.

What is changed and how it works?

Check List

Tests

Code changes

Side effects

Related changes
Should update doc.


This change is Reviewable

@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520
Copy link
Contributor Author

/run-all-tests

@codecov-io
Copy link

codecov-io commented Jan 4, 2019

Codecov Report

Merging #8941 into master will decrease coverage by 0.03%.
The diff coverage is 41.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8941      +/-   ##
==========================================
- Coverage   67.59%   67.56%   -0.04%     
==========================================
  Files         363      363              
  Lines       75317    75329      +12     
==========================================
- Hits        50913    50896      -17     
- Misses      19918    19940      +22     
- Partials     4486     4493       +7
Impacted Files Coverage Δ
sessionctx/variable/sysvar.go 100% <ø> (ø) ⬆️
sessionctx/variable/session.go 30% <0%> (-0.85%) ⬇️
session/session.go 72.85% <100%> (+0.03%) ⬆️
ddl/index.go 79.32% <55.55%> (-0.31%) ⬇️
util/systimemon/systime_mon.go 80% <0%> (-20%) ⬇️
ddl/delete_range.go 74.28% <0%> (-5.72%) ⬇️
sessionctx/variable/varsutil.go 25.78% <0%> (-1.89%) ⬇️
executor/index_lookup_join.go 77.28% <0%> (-0.64%) ⬇️
executor/join.go 78.29% <0%> (-0.41%) ⬇️
store/tikv/lock_resolver.go 42.65% <0%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b40b14...1fedbd2. Read the comment docs.

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao
Copy link
Contributor

winkyao commented Jan 7, 2019

Please remember to update the doc

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 7, 2019
@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520
Copy link
Contributor Author

@winkyao @zimulala PTAL again.

@crazycs520
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again.

ddl/util/util.go Outdated Show resolved Hide resolved
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
PTAL @zimulala again.

@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520
Copy link
Contributor Author

/run-all-tests

@jackysp jackysp merged commit 858b200 into pingcap:master Jan 10, 2019
crazycs520 added a commit to crazycs520/tidb that referenced this pull request Jan 21, 2019
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants