ddl: fix can't cancel a job when add index meets panic #8621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimulala
reviewed
Dec 12, 2018
|
/rebuild |
ciscoxll
reviewed
Dec 29, 2018
|
/run-all-tests |
|
Please Merge pingcap/check#12 first. |
|
/run-all-tests |
zimulala
reviewed
Jan 2, 2019
| checkErr = errors.Trace(errs[0]) | ||
| return | ||
| } | ||
| txn, err = hookCtx.Txn(true) |
There was a problem hiding this comment.
Why do you want to do it again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Before this PR, if TiDB panic in backfillIndexInTxn, we can't cancel the ddl job, because the handleBackfillTask check cancels state after the panic, and panic will be caught by recover(), and never know the job is canceled.
This change is