executor: Add Global to SHOW INDEX output | tidb-test=pr/2391

[samba-rgb]

What problem does this PR solve?

No info about index if its global or not , added in show index in this pr

Issue Number: close #55452

Problem Summary:

What changed and how does it work?

added Global index from index info

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[sre-bot]

All committers have signed the CLA.

[ti-chi-bot]

Welcome @samba-rgb!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

[ti-chi-bot]

Hi @samba-rgb. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiprow]

Hi @samba-rgb. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lance6716]

/ok-to-test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.9314%. Comparing base (ebf3146) to head (efbca50).
Report is 46 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #56028         +/-   ##
=================================================
- Coverage   72.9003%   56.9314%   -15.9689%     
=================================================
  Files          1604       1783        +179     
  Lines        446755     640621     +193866     
=================================================
+ Hits         325686     364715      +39029     
- Misses       101023     250956     +149933     
- Partials      20046      24950       +4904     

Flag	Coverage Δ
integration	39.5170% <62.5000%> (?)
unit	72.1813% <100.0000%> (+0.1770%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9567% <ø> (ø)
parser	∅ <ø> (∅)
br	61.9809% <ø> (+16.2097%)	⬆️

[mjonss]

Looks good, with some comments.
There are also more tests that needs to update (since the SHOW INDEX output changed).
You can run all unit tests with make dev and you can run integration tests by first building the tidb-server binary with make and then (cd tests/integrationtest ; ./run-tests.sh -s ../../bin/tidb-server)

[mjonss]

If PKIsHandle, then it is by definition a LOCAL index, i.e. each partition will have the clustered index, and the PK column must be a part of the partitioning expression.

Test by:

set tidb_enable_global_index = 0;
create table t (a int primary key clustered, b int) partition by hash (a) partitions 2;
show create table t;
show index from t;
set tidb_enable_global_index = 1;
show index from t;

[mjonss]

So here you can just use "NO"

Suggested change

	isGlobalIndex, // Global_index
	"NO", // Global_index

[mjonss]

Ah, sorry, I had not indented it correctly :(

[mjonss]

@samba-rgb I can fix the idc-jenkins-ci-tidb/mysql-test test failures. Can you fix the other failed tests?

[samba-rgb]

@mjonss Thank you for helping with my SQL test fix. I will now resume working on the fixes for integration and unit tests, along with addressing the comments mentioned above.

[samba-rgb]

Hi @mjonss i added the Global column in the integrationtest/r//.result path
example : tidb/tests/integrationtest/r/session/clustered_index.result
but still in the check_dev its not reflecting
is their any place that i need to change/add

BTW when i ran make dev no test case is running for me
find: md5sum: No such file or directory

[mjonss]

Hi @mjonss i added the Global column in the integrationtest/r//.result path example : tidb/tests/integrationtest/r/session/clustered_index.result but still in the check_dev its not reflecting is their any place that i need to change/add

BTW when i ran make dev no test case is running for me find: md5sum: No such file or directory

@samba-rgb
For the integration tests, you can simply re-record the result files, it seems like there is some formatting issues in your change, likely spaces instead of tabs. Try ./run-tests.sh -s ../../bin/tidb-server -r session/clustered_index and it will overwrite the .result file, and you can try with ./run-tests.sh -s ../../bin/tidb-server -t session/clustered_index to verify that it passes.

I assume you are using a mac? md5sum is md5 in macOs..., you can also run only the unit tests with make ut IIRC.
Also if there are a few integration tests that fails on mac, it is due to floating point difference between arm and i386, so leave them as-is.

I will try to find which unit tests still needing to be updated.

[mjonss]

pkg/ddl/db_change_test.go:857
Error: Received unexpected error:
need [[t 0 PRIMARY 1 c1 A 0 BTREE YES NO]], but got [[t 0 PRIMARY 1 c1 A 0 BTREE YES NO NO]]
Test: TestShowIndex

To run the test you must also enable failpoints, make failpoint-enable, which you then can disable before committing, make failpoint-disable
Maybe this patch file could help?
56028.patch

[mjonss]

Thank you for your contribution! Approved.

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-09-19 13:15:32.118205208 +0000 UTC m=+1139801.858629146: ☑️ agreed by mjonss.
• 2024-09-19 13:30:09.190267371 +0000 UTC m=+1140678.930691310: ☑️ agreed by lance6716.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, mjonss, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lance6716,mjonss,winoros]
• pkg/ddl/OWNERS [lance6716]
• pkg/planner/OWNERS [winoros]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment