Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: improve priority of suppressErrorTooLongKeyKey for DM #55164

Merged
merged 5 commits into from
Aug 9, 2024

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Aug 2, 2024

What problem does this PR solve?

Issue Number: close #55138

Problem Summary:

seems suppressErrorTooLongKeyKey is only used by DM, so increase its priority

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 2, 2024
Copy link

tiprow bot commented Aug 2, 2024

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.4382%. Comparing base (0a2d5be) to head (86f3656).
Report is 157 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55164        +/-   ##
================================================
+ Coverage   74.8131%   75.4382%   +0.6251%     
================================================
  Files          1570       1570                
  Lines        364718     439704     +74986     
================================================
+ Hits         272857     331705     +58848     
- Misses        72124      87472     +15348     
- Partials      19737      20527       +790     
Flag Coverage Δ
integration 50.5542% <100.0000%> (?)
unit 71.7828% <100.0000%> (-1.9661%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (-2.2327%) ⬇️
parser ∅ <ø> (∅)
br 63.1513% <ø> (+15.4606%) ⬆️

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 8, 2024
@lance6716 lance6716 changed the title [WIP]dm tracker: tolerate customized max-index-length in downstream cluster ddl: improve priority of suppressErrorTooLongKeyKey for DM Aug 8, 2024
@ti-chi-bot ti-chi-bot bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-tests-checked labels Aug 8, 2024
@lance6716 lance6716 requested a review from GMHDBJD August 8, 2024 06:22
@lance6716
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Aug 8, 2024

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: lance6716 <lance6716@gmail.com>
pkg/ddl/schematracker/dm_tracker.go Outdated Show resolved Hide resolved
pkg/ddl/index.go Outdated Show resolved Hide resolved
pkg/ddl/index.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 8, 2024
@D3Hunter
Copy link
Contributor

D3Hunter commented Aug 8, 2024

/hold

for comments

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2024
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 8, 2024
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 8, 2024
Copy link

ti-chi-bot bot commented Aug 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-08 09:48:17.512538173 +0000 UTC m=+518227.379637272: ☑️ agreed by D3Hunter.
  • 2024-08-08 10:22:44.471189852 +0000 UTC m=+520294.338288938: ☑️ agreed by GMHDBJD.

@D3Hunter
Copy link
Contributor

D3Hunter commented Aug 8, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2024
Copy link

ti-chi-bot bot commented Aug 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, GMHDBJD, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 9, 2024
@ti-chi-bot ti-chi-bot bot merged commit 5d867dd into pingcap:master Aug 9, 2024
24 checks passed
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Aug 30, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 30, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #55772.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DM schema tracker can't create unique or composite indexes longer than default max-index-length
5 participants