Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: replace local ingest impl with backfill operators (#54149) #54225

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #54149

What problem does this PR solve?

Issue Number: close #53909, close #53910

Problem Summary: See #53909 (comment)

What changed and how does it work?

Before fixing the context usage, I prefer to unify local ingest and distributed ingest implementation, remove the old ingestBackfillScheduler.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.2 labels Jun 26, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 26, 2024
Copy link

ti-chi-bot bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 26, 2024
Copy link

ti-chi-bot bot commented Jun 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-26 06:25:20.851303192 +0000 UTC m=+787247.336792024: ☑️ agreed by tangenta.
  • 2024-06-26 06:31:22.54624159 +0000 UTC m=+787609.031730505: ☑️ agreed by lance6716.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 68.46154% with 82 lines in your changes missing coverage. Please review.

Project coverage is 54.9326%. Comparing base (b3ed886) to head (11c56fc).
Report is 1 commits behind head on release-8.2.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           release-8.2     #54225         +/-   ##
====================================================
- Coverage      72.8667%   54.9326%   -17.9341%     
====================================================
  Files             1519       1638        +119     
  Lines           435373     606586     +171213     
====================================================
+ Hits            317242     333214      +15972     
- Misses           98583     251053     +152470     
- Partials         19548      22319       +2771     
Flag Coverage Δ
integration 34.5515% <22.3076%> (?)
unit 71.7955% <67.6923%> (-0.0801%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 46.4613% <ø> (+0.3129%) ⬆️

@tangenta
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 26, 2024
@tangenta
Copy link
Contributor

/retest

1 similar comment
@tangenta
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 50d888e into pingcap:release-8.2 Jun 26, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants