Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: avoid growslices in the infoSchema.SchemaTables #54023

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jun 14, 2024

What problem does this PR solve?

Issue Number: close #54021

Problem Summary:

What changed and how does it work?

(*infoSchema).SchemaTables take too many time on growslics

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.3227%. Comparing base (f713512) to head (2b8d78c).

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54023         +/-   ##
=================================================
- Coverage   74.4712%   50.3227%   -24.1485%     
=================================================
  Files          1508       1628        +120     
  Lines        358501     599944     +241443     
=================================================
+ Hits         266980     301908      +34928     
- Misses        72085     275073     +202988     
- Partials      19436      22963       +3527     
Flag Coverage Δ
integration 21.7974% <75.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 55.1994% <ø> (ø)
parser ∅ <ø> (∅)
br 46.7635% <ø> (+2.8950%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 14, 2024
Copy link

ti-chi-bot bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 14, 2024
Copy link

ti-chi-bot bot commented Jun 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-14 04:14:40.225605905 +0000 UTC m=+697234.278917828: ☑️ agreed by ywqzzy.
  • 2024-06-14 04:29:44.30076316 +0000 UTC m=+698138.354075084: ☑️ agreed by D3Hunter.

@ti-chi-bot ti-chi-bot bot merged commit bb3a4d2 into pingcap:master Jun 14, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(*infoSchema).SchemaTables take too many time on growslics
3 participants