statistics: add more comments to FMSketch #52841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Rustin170506
added
the
skip-issue-check
ti-chi-bot
bot
added
release-note-none
Rustin170506
commented
Apr 23, 2024
Rustin170506
requested review from
hawkingrei and
winoros
and removed request for
hawkingrei
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
hawkingrei
reviewed
Apr 23, 2024
Co-authored-by: Weizhen Wang <wangweizhen@pingcap.com>
hawkingrei
approved these changes
Apr 23, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52841 +/- ##
================================================
+ Coverage 72.3203% 75.0619% +2.7416%
================================================
Files 1473 1481 +8
Lines 427447 437091 +9644
================================================
+ Hits 309131 328089 +18958
+ Misses 99018 89190 -9828
- Partials 19298 19812 +514
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
winoros
approved these changes
Apr 24, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close None
Problem Summary:
What changed and how does it work?
Added more comments to FMSketch algorithm.
Used the same const value to init the FMSketch.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.