Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttl: remove TTL job when the table has been dropped (#51541) #51620

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #51541

What problem does this PR solve?

Issue Number: close #51540

Problem Summary:

What changed and how does it work?

  1. Finish the job when the table is no longer a TTL table (or has been dropped).
  2. GC will also remove tidb_ttl_table_status when the table is no longer a TTL table (or has been dropped).

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 8, 2024
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. label Mar 8, 2024
@YangKeao YangKeao requested a review from lcwangchao March 8, 2024 07:03
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@YangKeao YangKeao force-pushed the cherry-pick-51541-to-release-7.1 branch from 96d6d74 to 35aec7a Compare March 8, 2024 07:53
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@a8b650f). Click here to learn what that means.
The diff coverage is 72.2222%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #51620   +/-   ##
================================================
  Coverage               ?   73.4437%           
================================================
  Files                  ?       1212           
  Lines                  ?     379571           
  Branches               ?          0           
================================================
  Hits                   ?     278771           
  Misses                 ?      83002           
  Partials               ?      17798           

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [YangKeao,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 8, 2024
Copy link

ti-chi-bot bot commented Mar 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-08 08:18:32.419355582 +0000 UTC m=+414339.441601971: ☑️ agreed by lcwangchao.
  • 2024-03-08 08:46:57.080041622 +0000 UTC m=+416044.102288009: ☑️ agreed by YangKeao.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 11, 2024
@ti-chi-bot ti-chi-bot bot merged commit f4401e9 into pingcap:release-7.1 Mar 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants