-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility: SQL_SELECT_LIMIT worked in show statement; #33696
Compatibility: SQL_SELECT_LIMIT worked in show statement; #33696
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-mysql-test |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/13bc294f5678a0f92e25f5ed90a04bdd07cf06b4 |
e41a74e
to
3173451
Compare
/run-mysql-test |
f4489c1
to
7558dfd
Compare
b975684
to
6807470
Compare
/run-mysql-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
36c5c88
to
13bc294
Compare
/run-mysql-test |
7f03734
to
39eec54
Compare
2a002c7
to
d36f928
Compare
Please Approve |
/run-unit-test |
/run-mysql-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
/run-mysql-test |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 19426fa
|
TiDB MergeCI notify🔴 Bad News! [1] CI still failing after this pr merged.
|
issue #33407
What problem does this PR solve?
Issue Number: close #33407
Problem Summary:
What is changed and how it works?
The supported Show stmts are go through to find out what stmts should be influenced by SelectLimit value on return result set row numbers. The Limit executor is added into plan tree for show stmts to archieve the requirement.
Check List
Tests
Release note