Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: clean up MemoizeStr function #11450

Merged
merged 5 commits into from
Jul 26, 2019
Merged

util: clean up MemoizeStr function #11450

merged 5 commits into from
Jul 26, 2019

Conversation

ngaut
Copy link
Member

@ngaut ngaut commented Jul 25, 2019

Tiny clean up.

@codecov
Copy link

codecov bot commented Jul 25, 2019 •
edited
Loading

Codecov Report

Merging #11450 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11450   +/-   ##
===========================================
  Coverage   81.3904%   81.3904%           
===========================================
  Files           424        424           
  Lines         90862      90862           
===========================================
  Hits          73953      73953           
  Misses        11598      11598           
  Partials       5311       5311

@ngaut ngaut added the type/enhancement The issue or PR belongs to an enhancement. label Jul 26, 2019
@ngaut
Copy link
Member Author

ngaut commented Jul 26, 2019

/run-all-tests

lysu
lysu reviewed Jul 26, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added status/all tests passed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 26, 2019
@lysu lysu requested a review from jackysp July 26, 2019 10:53
jackysp
jackysp approved these changes Jul 26, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 26, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Jul 26, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jul 26, 2019

@ngaut merge failed.

@lysu
Copy link
Contributor

lysu commented Jul 26, 2019

/run-all-tests

@zz-jason zz-jason merged commit e220499 into pingcap:master Jul 26, 2019
@ngaut ngaut deleted the ngaut/clean-up branch July 27, 2019 14:50
@lance6716 lance6716 mentioned this pull request Jul 3, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu left review comments

@jackysp jackysp jackysp approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ngaut @sre-bot @lysu @jackysp @zz-jason