Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: tiny refactor #11244

Merged
merged 3 commits into from
Jul 15, 2019
Merged

planner: tiny refactor #11244

merged 3 commits into from
Jul 15, 2019

Conversation

ngaut
Copy link
Member

@ngaut ngaut commented Jul 14, 2019

Make source code more go style.

@mahjonp
Copy link
Contributor

mahjonp commented Jul 14, 2019

/rebuild

@codecov
Copy link

codecov bot commented Jul 14, 2019 •
edited
Loading

Codecov Report

Merging #11244 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11244   +/-   ##
===========================================
  Coverage   81.3398%   81.3398%           
===========================================
  Files           423        423           
  Lines         90326      90326           
===========================================
  Hits          73471      73471           
  Misses        11567      11567           
  Partials       5288       5288

shenli
shenli reviewed Jul 14, 2019
View reviewed changes
Copy link
Member

@shenli shenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenli shenli added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner labels Jul 14, 2019
@ngaut ngaut added component/DDL-need-LGT3 status/LGT1 Indicates that a PR has LGTM 1. and removed component/DDL-need-LGT3 labels Jul 15, 2019
alivxxx
alivxxx approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 15, 2019
@alivxxx
Copy link
Contributor

alivxxx commented Jul 15, 2019

/run-all-tests

lonng
lonng approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngaut ngaut merged commit 8f61bfa into pingcap:master Jul 15, 2019
@ngaut ngaut deleted the go-style branch July 15, 2019 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenli shenli shenli left review comments

@lonng lonng lonng approved these changes

@alivxxx alivxxx alivxxx approved these changes

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ngaut @mahjonp @alivxxx @shenli @lonng