Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TableCommon.getCols() can be memorized #53604

Closed
ekexium opened this issue May 28, 2024 · 0 comments · Fixed by #53605
Closed

TableCommon.getCols() can be memorized #53604

ekexium opened this issue May 28, 2024 · 0 comments · Fixed by #53605
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@ekexium
Copy link
Contributor

ekexium commented May 28, 2024 •
edited
Loading

Enhancement

Every call of getCols() re-calculates the result, which is time-consuming. Since we assume the schema of the table won't change in the lifetime of a TableCommon struct, we can memoize the function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

table: memoize TableCommon.getCols ekexium/tidb
1 participant
@ekexium