Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RelatedTables returns nothing if the statement fails to build logical plan #50988

Closed
CbcWestwolf opened this issue Feb 5, 2024 · 0 comments · Fixed by #50989
Closed

RelatedTables returns nothing if the statement fails to build logical plan #50988

CbcWestwolf opened this issue Feb 5, 2024 · 0 comments · Fixed by #50989
Assignees
@CbcWestwolf
Labels
affects-7.1 affects-7.5 affects-8.1 severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@CbcWestwolf
Copy link
Member

Bug Report

In our audit log implementation, it uses RelatedTables to get the tables list for latter filtering. However, if the statement fails to build logical plan, return e.sc.Tables will return nothing, makes the audit log filter fail to work.
@CbcWestwolf CbcWestwolf self-assigned this Feb 5, 2024
@ti-chi-bot ti-chi-bot bot added may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 labels Feb 5, 2024
@CbcWestwolf CbcWestwolf mentioned this issue Feb 5, 2024
Merged
13 tasks
@CbcWestwolf CbcWestwolf removed may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 labels Feb 5, 2024
@jebter jebter added the sig/sql-infra SIG: SQL Infra label Feb 17, 2024
ti-chi-bot bot pushed a commit that referenced this issue May 8, 2024
@CbcWestwolf
extension: make RelatedTables work when the statement fails (#50989)
fe7c324 
close #50988
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this issue May 16, 2024
@CbcWestwolf @ti-chi-bot
extension: make RelatedTables work when the statement fails (pingca…
b5d0bcd 
…p#50989)

close pingcap#50988
This was referenced May 16, 2024
Merged
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this issue May 16, 2024
@CbcWestwolf @ti-chi-bot
extension: make RelatedTables work when the statement fails (pingca…
cd5a32a 
…p#50989)

close pingcap#50988
@ti-chi-bot ti-chi-bot mentioned this issue May 16, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue May 16, 2024
@ti-chi-bot
extension: make RelatedTables work when the statement fails (#50989) (
ff5eb17 
#53308)

close #50988
ti-chi-bot bot pushed a commit that referenced this issue May 16, 2024
@ti-chi-bot
extension: make RelatedTables work when the statement fails (#50989) (
a5c0b91 
#53309)

close #50988
ti-chi-bot bot pushed a commit that referenced this issue May 16, 2024
@ti-chi-bot
extension: make RelatedTables work when the statement fails (#50989) (
ce9e337 
#53310)

close #50988
terry1purcell pushed a commit to terry1purcell/tidb that referenced this issue May 17, 2024
@CbcWestwolf @terry1purcell
extension: make RelatedTables work when the statement fails (pingca…
b4ef2ff 
…p#50989)

close pingcap#50988
RidRisR pushed a commit to RidRisR/tidb that referenced this issue May 23, 2024
@CbcWestwolf @RidRisR
extension: make RelatedTables work when the statement fails (pingca…
c1fa508 
…p#50989)

close pingcap#50988
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CbcWestwolf CbcWestwolf

Labels
affects-7.1 affects-7.5 affects-8.1 severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

extension: make RelatedTables work when the statement fails CbcWestwolf/tidb
3 participants
@jebter @CbcWestwolf @ti-chi-bot