Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't write HOME env variable #86

Merged
merged 3 commits into from
Jun 20, 2014
Merged

Conversation

imanel
Copy link
Contributor

@imanel imanel commented Jun 2, 2014

Loading HOME variable breaks multi-user container (i.e. logging as postgres user) if you try to load variables via /etc/container_environment.sh.

Loading HOME variable breaks multi-user container (i.e. logging as postgres user) if you try to load variables via `/etc/container_environment.sh`.
@FooBarWidget
Copy link
Member

Yes, good point. Could you also exclude USER, UID, GID, GROUP and SHELL?

@FooBarWidget FooBarWidget added this to the 0.9.11 milestone Jun 17, 2014
@imanel
Copy link
Contributor Author

imanel commented Jun 18, 2014

Updated.

@FooBarWidget
Copy link
Member

I think it's not right. You call break but shouldn't that be continue?

@imanel
Copy link
Contributor Author

imanel commented Jun 20, 2014

You're right - fixed.

FooBarWidget added a commit that referenced this pull request Jun 20, 2014
Don't write HOME env variable
@FooBarWidget FooBarWidget merged commit d0e63da into phusion:master Jun 20, 2014
@FooBarWidget
Copy link
Member

Thanks for the patch.

guedressel pushed a commit to protosrc/baseimage-docker that referenced this pull request Oct 31, 2017
Don't write HOME env variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants