Write task progress to error output #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veewee
reviewed
Sep 1, 2017
| @@ -34,6 +35,10 @@ class ProgressSubscriber implements EventSubscriberInterface | |||
| */ | |||
| public function __construct(OutputInterface $output, ProgressBar $progressBar) | |||
| { | |||
| if ($output instanceof ConsoleOutputInterface) { | |||
There was a problem hiding this comment.
Shouldn't this be fixed here instead?
https://github.com/phpro/grumphp/blob/master/src/Console/Helper/TaskRunnerHelper.php#L96
There was a problem hiding this comment.
I also agree with @veewee
|
Hi @jyggen, Do you agree with the comments above? |
|
Sorry for my inactivity here, but hopefully the PR looks better now! Whether it's better to output everything to stdout instead of stderr is something worth discussing indeed, but the point of this PR is simply to normalize the usage. I've seen build systems where stdout and stderr are sent to different places/files, and it looks really weird when the task names end up in one place and ✔ and ✘ in another :) |
|
Thank you @jyggen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently things that uses
$this->output(like✔and✘) writes to stdout while everything that utilizes ProgressBar usually writes to stderr. This PR simply replicates how ProgressBar handles output internally to make output a bit more consistent.